Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move storage directory into the app directory #894

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 31, 2023

Part of Separate internal application files from project structure #873

This directory only used by the internal underlying Laravel application, and there is really no reason for a user to interact with it, so there's no point in having it clog up the root structure. Instead it makes more sense to have it in the app directory that already houses files for the Laravel app.

This directory only used by the internal underlying Laravel application, and there is really no reason for a user to interact with it, so there's no point in having it clog up the root structure. Instead it makes more sense to have it in the app directory that already houses files for the Laravel app.
@caendesilva caendesilva force-pushed the move-storage-directory-into-app-directory branch from 4bb47d8 to d547ae6 Compare January 31, 2023 10:12
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #894 (d547ae6) into separate-internal-application-files-from-project-structure- (158ae9b) will not change coverage.
The diff coverage is n/a.

@@                                        Coverage Diff                                        @@
##             separate-internal-application-files-from-project-structure-      #894     +/-   ##
=================================================================================================
  Coverage                                                         100.00%   100.00%             
+ Complexity                                                          2520      1260   -1260     
=================================================================================================
  Files                                                                292       146    -146     
  Lines                                                               6578      3289   -3289     
=================================================================================================
- Hits                                                                6578      3289   -3289     
Impacted Files Coverage Δ
.../packages/framework/src/Foundation/Application.php 100.00% <0.00%> (ø)
...rk/src/Console/Commands/PackageDiscoverCommand.php
packages/framework/src/Foundation/Application.php
...uildTasks/PostBuildTasks/GenerateBuildManifest.php
...es/framework/src/Console/Commands/DebugCommand.php
...mework/src/Framework/Services/BuildTaskService.php
.../framework/src/Framework/Services/AssetService.php
...src/Framework/Actions/CreatesNewPageSourceFile.php
...c/Framework/Actions/ConvertsArrayToFrontMatter.php
packages/framework/src/Facades/Site.php
... and 137 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review January 31, 2023 10:19
@caendesilva caendesilva merged commit 7f5b1e9 into separate-internal-application-files-from-project-structure- Jan 31, 2023
@caendesilva caendesilva deleted the move-storage-directory-into-app-directory branch January 31, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant